Add decodeEventData and decodeEventKey functions and test cases #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wk3368
reviewed
May 26, 2021
src/index.ts
Outdated
| @@ -7,4 +7,5 @@ export * as onchain_event_types from './lib/runtime/onchain_events'; | |||
| export * as providers from './providers'; | |||
| export * as crypto_hash from './crypto_hash'; | |||
| export * as encoding from './encoding'; | |||
| export * as decode_event from './onchain-events/decode-event'; | |||
There was a problem hiding this comment.
change
onchain-events/decode-event
to
onchain_events/decode_event
new folder/files name should keep the same name pattern with the older ones.
| const eventData = '0x00ca9a3b00000000000000000000000000000000000000000000000000000001035354430353544300'; | ||
| const result = decodeEventData(eventName, eventData); | ||
| console.log(result.toJS()); | ||
| }); |
There was a problem hiding this comment.
const result = decodeEventData(eventName, eventData);
console.log(result.toJS());
thses two method should merge into one , and exported to the merged one
src/onchain-events/decode-event.ts
Outdated
|
|
||
| export function decodeEventKey(eventKey: string): any { | ||
| return decode_event_key(eventKey); | ||
| } |
There was a problem hiding this comment.
we should move these 2 exported methods from this folder to the encoding folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.