[gen]update golang gen code #3007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolestar
reviewed
Nov 2, 2021
| @@ -621,14 +700,24 @@ func decode_{0}_argument(arg diemtypes.TransactionArgument) (value {1}, err erro | |||
| Address => "diemtypes.AccountAddress".into(), | |||
| Vector(type_tag) => match type_tag.as_ref() { | |||
| U8 => "[]byte".into(), | |||
| U128 => "diemtypes.VecU128".into(), | |||
There was a problem hiding this comment.
diemtypes 这个 prefix 是不是也可以考虑改一下？要不就改成 movetypes ？
Comment on lines
+626
to
+630
| Bool => format!("TransactionArgument__Bool(value={})", name), | ||
| U8 => format!("TransactionArgument__U8(value={})", name), | ||
| U64 => format!("TransactionArgument__U64(value={})", name), | ||
| U128 => format!("TransactionArgument__U128(value={})", name), | ||
| Address => format!("TransactionArgument__Address(value={})", name), |
|
|
||
| #[ignore] | ||
| #[test] | ||
| fn test_that_golang_code_compiles_and_demo_runs() { |
There was a problem hiding this comment.
是不是我们考虑在 ci 上安装环境，把这个 test 打开，保证每次修改都能正常生成代码
jolestar
reviewed
Nov 2, 2021
| @@ -515,6 +584,9 @@ var script_function_decoder_map = map[string]func(diemtypes.TransactionPayload) | |||
| Address => ("Address", "value = arg.Value".into()), | |||
| Vector(type_tag) => match type_tag.as_ref() { | |||
| U8 => ("U8Vector", default_stmt), | |||
| U128 => ("VecU128", default_stmt), | |||
There was a problem hiding this comment.
每支持一种 vector 就要增加一个新类型，感觉有点笨，但貌似暂时也没很好的办法。以后考虑支持泛型的语言可以用更优雅一些的办法。提过一个 issue diem/diem#8628
sanlee42
requested changes
Nov 2, 2021
Comment on lines
+626
to
+630
| Bool => format!("TransactionArgument__Bool(value={})", name), | ||
| U8 => format!("TransactionArgument__U8(value={})", name), | ||
| U64 => format!("TransactionArgument__U64(value={})", name), | ||
| U128 => format!("TransactionArgument__U128(value={})", name), | ||
| Address => format!("TransactionArgument__Address(value={})", name), |
|
starcoin_types.yml 文件会自动重新生成 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.