Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import blocks before test #3364

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

yourmoonlight
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

import full blocks before test

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #3364 (1b961b9) into master (6ac5aab) will increase coverage by 0.32%.
The diff coverage is n/a.

❗ Current head 1b961b9 differs from pull request most recent head 604742d. Consider uploading reports for the commit 604742d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3364      +/-   ##
==========================================
+ Coverage   31.74%   32.06%   +0.32%     
==========================================
  Files         500      500              
  Lines       46815    46815              
  Branches    21312    21312              
==========================================
+ Hits        14858    15005     +147     
+ Misses      17809    17679     -130     
+ Partials    14148    14131      -17     
Flag Coverage Δ
unittests 32.06% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
types/src/account_state.rs 63.34% <0.00%> (-3.33%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 32.56% <0.00%> (-3.10%) ⬇️
sync/src/block_connector/metrics.rs 24.25% <0.00%> (-3.03%) ⬇️
commons/stream-task/src/tests.rs 33.47% <0.00%> (-1.59%) ⬇️
chain/open-block/src/lib.rs 33.12% <0.00%> (-1.32%) ⬇️
storage/src/cache_storage/mod.rs 41.98% <0.00%> (-1.23%) ⬇️
commons/stream-task/src/event.rs 32.78% <0.00%> (-1.11%) ⬇️
vm/compiler/src/lib.rs 38.74% <0.00%> (-0.90%) ⬇️
storage/src/db_storage/mod.rs 44.69% <0.00%> (-0.85%) ⬇️
commons/accumulator/src/inmemory/mod.rs 72.31% <0.00%> (-0.76%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac5aab...604742d. Read the comment docs.

@github-actions
Copy link

Benchmark for d42a4bb

Click to view benchmark
Test Base PR %
accumulator_append 587.7±11.98µs 589.2±12.12µs +0.26%
block_apply/block_apply_10 265.2±1.30ms 264.0±0.87ms -0.45%
block_apply/block_apply_1000 26.9±0.02s 26.9±0.02s 0.00%
get_with_proof/db_store 36.8±0.24µs 36.2±0.29µs -1.63%
get_with_proof/mem_store 31.8±0.15µs 31.3±0.20µs -1.57%
put_and_commit/db_store/1 96.4±4.93µs 95.8±4.92µs -0.62%
put_and_commit/db_store/10 865.4±57.14µs 861.8±40.87µs -0.42%
put_and_commit/db_store/100 7.4±0.32ms 7.4±0.31ms 0.00%
put_and_commit/db_store/5 419.9±23.23µs 439.6±22.73µs +4.69%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 62.8±5.76µs 62.4±5.67µs -0.64%
put_and_commit/mem_store/10 583.2±47.87µs 584.4±50.21µs +0.21%
put_and_commit/mem_store/100 5.7±0.34ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 296.8±25.08µs 296.4±27.88µs -0.13%
put_and_commit/mem_store/50 2.9±0.18ms 2.8±0.19ms -3.45%
query_block/query_block_in(10)_times(100) 3.9±0.11ms 3.9±0.11ms 0.00%
query_block/query_block_in(10)_times(1000) 39.4±1.04ms 39.2±0.73ms -0.51%
query_block/query_block_in(10)_times(10000) 387.5±5.95ms 388.6±5.93ms +0.28%
query_block/query_block_in(1000)_times(100) 972.2±7.14µs 961.2±7.82µs -1.13%
query_block/query_block_in(1000)_times(1000) 9.7±0.05ms 9.7±0.04ms 0.00%
query_block/query_block_in(1000)_times(10000) 97.3±0.78ms 96.3±1.01ms -1.03%
storage_transaction 1062.2±281.22µs 1071.9±309.33µs +0.91%
vm/transaction_execution/1 313.3±0.43ms 314.0±0.96ms +0.22%
vm/transaction_execution/10 99.5±0.49ms 99.1±0.45ms -0.40%
vm/transaction_execution/20 92.1±0.15ms 93.0±1.63ms +0.98%
vm/transaction_execution/5 120.6±0.33ms 121.0±0.64ms +0.33%
vm/transaction_execution/50 106.5±0.17ms 106.8±0.30ms +0.28%

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需求是 #923

Comment on lines 45 to 48
- name: import blocks
run: |
ls -ls `pwd`/target
bash ./scripts/import_block.sh main ~/.starcoin/main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 import_block.sh 没有用。

env:
RUST_LOG: info
RUST_BACKTRACE: full
STARCOIN_WS: ${{ secrets.STARCOIN_WS }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要用 ci 跑起来的那个节点去测试。

args: --all
- name: import blocks
run: |
bash ./scripts/import_net_block.sh main ~/.starcoin/main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉应该拉个 release 版本的去测试,import 执行会很慢。

run: |
bash ./scripts/import_net_block.sh main ~/.starcoin/main
- name: test
run: bash ./scripts/auto_rerun_test.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个测试就没必要跑了。

Comment on lines 51 to 57
- name: move-prover-test
uses: actions-rs/cargo@v1
with:
command: test
args: -p starcoin-move-prover
- name: check changed files
run: bash ./scripts/changed_files.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个测试也一样

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants