Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify modules for ci #3758

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add verify modules for ci #3758

wants to merge 3 commits into from

Conversation

yourmoonlight
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #3758 (545383f) into master (3884c4b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3758      +/-   ##
==========================================
- Coverage   53.69%   53.67%   -0.02%     
==========================================
  Files         594      594              
  Lines       64116    64116              
==========================================
- Hits        34418    34405      -13     
- Misses      29698    29711      +13
Flag Coverage Δ
unittests 53.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
types/src/sync_status.rs 65.08% <0.00%> (-12.69%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 69.79% <0.00%> (-6.11%) ⬇️
network-p2p/src/protocol/generic_proto/handler.rs 79.78% <0.00%> (+0.28%) ⬆️
commons/service-registry/src/service_actor.rs 75.21% <0.00%> (+0.83%) ⬆️
commons/service-registry/src/bus/sys_bus.rs 89.31% <0.00%> (+1.26%) ⬆️
...rc/protocol/generic_proto/upgrade/notifications.rs 92.23% <0.00%> (+1.35%) ⬆️
network/api/src/tests.rs 95.00% <0.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3884c4b...545383f. Read the comment docs.

@github-actions
Copy link

Benchmark for f148d57

Click to view benchmark
Test Base PR %
accumulator_append 614.4±31.28µs 609.2±12.54µs -0.85%
block_apply/block_apply_10 945.6±6.93ms 945.1±3.03ms -0.05%
block_apply/block_apply_1000 95.4±0.03s 95.8±0.12s +0.42%
get_with_proof/db_store 36.6±0.38µs 36.3±0.27µs -0.82%
get_with_proof/mem_store 31.8±0.21µs 31.3±0.21µs -1.57%
put_and_commit/db_store/1 97.2±5.07µs 96.5±5.35µs -0.72%
put_and_commit/db_store/10 869.4±55.50µs 868.4±40.40µs -0.12%
put_and_commit/db_store/100 7.4±0.30ms 7.4±0.30ms 0.00%
put_and_commit/db_store/5 441.2±22.24µs 442.6±23.90µs +0.32%
put_and_commit/db_store/50 3.8±0.16ms 3.9±0.19ms +2.63%
put_and_commit/mem_store/1 61.5±5.77µs 62.1±5.92µs +0.98%
put_and_commit/mem_store/10 574.4±50.31µs 576.6±48.57µs +0.38%
put_and_commit/mem_store/100 5.7±0.86ms 5.6±0.37ms -1.75%
put_and_commit/mem_store/5 289.8±24.99µs 291.3±25.39µs +0.52%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 6.1±0.19ms 6.2±0.27ms +1.64%
query_block/query_block_in(10)_times(1000) 61.9±2.85ms 62.5±1.33ms +0.97%
query_block/query_block_in(10)_times(10000) 620.3±24.12ms 630.0±11.49ms +1.56%
query_block/query_block_in(1000)_times(100) 997.7±10.72µs 1011.4±13.63µs +1.37%
query_block/query_block_in(1000)_times(1000) 10.0±0.14ms 10.1±0.11ms +1.00%
query_block/query_block_in(1000)_times(10000) 100.8±0.98ms 101.0±1.11ms +0.20%
storage_transaction 1081.6±281.61µs 1114.2±337.03µs +3.01%
vm/transaction_execution/1 1048.0±2.91ms 1046.8±5.37ms -0.11%
vm/transaction_execution/10 244.2±1.68ms 242.3±0.63ms -0.78%
vm/transaction_execution/20 204.6±1.11ms 203.1±0.85ms -0.73%
vm/transaction_execution/5 330.9±2.75ms 332.8±5.23ms +0.57%
vm/transaction_execution/50 219.1±1.47ms 219.3±2.27ms +0.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar Awaiting requested review from jolestar jolestar will be requested when the pull request is marked ready for review jolestar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yourmoonlight