Network reconstruction #3900
Merged
Network reconstruction #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzhhuang
changed the title
nkysg
reviewed
May 25, 2023
|
|
||
| impl BusinessLayerHandle for PeerInfo { | ||
| fn handshake(&self, peer_info: &[u8]) -> Result<(), (&'static str, String)> { | ||
| let other_chain_info = ChainInfo::decode(peer_info).unwrap(); |
There was a problem hiding this comment.
这些地方unwrap()失败是不是直接导致节点崩溃了？
nkysg
reviewed
May 25, 2023
Benchmark for 92afc23Click to view benchmark
|
Benchmark for b88260eClick to view benchmark
|
Codecov Report
@@ Coverage Diff @@
## master #3900 +/- ##
==========================================
+ Coverage 53.73% 53.89% +0.16%
==========================================
Files 618 619 +1
Lines 68014 68233 +219
==========================================
+ Hits 36539 36764 +225
+ Misses 31475 31469 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sanlee42
approved these changes
Jun 5, 2023
nkysg
force-pushed
the
network-reconstruction
branch
from
cec8d55
to
66f54ea
Compare
7 tasks
2, resolve the compatibility issue
jackzhhuang
force-pushed
the
network-reconstruction
branch
from
9754fa9
to
5c1b619
Compare
Benchmark for 0c8613fClick to view benchmark
|
nkysg
reviewed
Jun 21, 2023
nkysg
reviewed
Jun 21, 2023
network/src/service.rs
Outdated
| self.network_service.update_business_status( | ||
| ChainStatus::new(msg.compact_block.header.clone(), msg.block_info.clone()) | ||
| .encode() | ||
| .unwrap(), |
There was a problem hiding this comment.
这里ChainStatus::new变量是不是encode一定会成功？是的话这个unwrap()改成expect
sanlee42
reviewed
Jun 21, 2023
| } | ||
|
|
||
| impl BusinessLayerHandle for Networkp2pHandle { | ||
| fn handshake( |
There was a problem hiding this comment.
建议此处只对 status 进行处理，根据其返回状态来处理 notifications_sink和 CustomMessageOutcome，这两个在network这层不关心，放到 network-p2p里面比较合理。
There was a problem hiding this comment.
已修改，我重新测试一下，跑main和Barnard 1-2天的时间
Benchmark for bf074b5Click to view benchmark
|
nkysg
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information