Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #3902

Merged
merged 2 commits into from Jun 2, 2023
Merged

fix typos #3902

merged 2 commits into from Jun 2, 2023

Conversation

simonjiao
Copy link
Collaborator

@simonjiao simonjiao commented May 30, 2023 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested a review from nkysg May 30, 2023 09:14
@sanlee42
Copy link
Member

sanlee42 commented Jun 1, 2023

runing cargo fmt && cargo clippy for the code formating and checking

@nkysg
Copy link
Collaborator

nkysg commented Jun 1, 2023

bash ./scripts/check_commit.sh

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #3902 (f64ae1c) into master (397b411) will increase coverage by 0.05%.
The diff coverage is 85.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3902      +/-   ##
==========================================
+ Coverage   53.68%   53.72%   +0.05%     
==========================================
  Files         618      618              
  Lines       67991    68134     +143     
==========================================
+ Hits        36492    36598     +106     
- Misses      31499    31536      +37
Flag Coverage Δ
unittests 53.72% <85.45%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/lib.rs 60.08% <0.00%> (-0.65%) ⬇️
txpool/mock-service/src/lib.rs 41.54% <0.00%> (ø)
vm/types/src/on_chain_config/mod.rs 71.14% <ø> (ø)
vm/transaction-builder/src/lib.rs 32.65% <50.00%> (+0.29%) ⬆️
commons/service-registry/src/service_registry.rs 64.13% <66.67%> (ø)
vm/types/src/on_chain_config/gas_schedule.rs 98.37% <70.00%> (-0.10%) ⬇️
genesis/src/lib.rs 82.05% <83.02%> (+0.15%) ⬆️
config/src/genesis_config.rs 81.84% <100.00%> (+0.94%) ⬆️
txpool/src/tx_pool_service_impl.rs 79.01% <100.00%> (ø)
.../types/src/on_chain_config/genesis_gas_schedule.rs 90.72% <100.00%> (+1.26%) ⬆️

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626325a...f64ae1c. Read the comment docs.

@nkysg nkysg merged commit 96c7e1f into starcoinorg:master Jun 2, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanlee42 sanlee42 sanlee42 approved these changes

@nkysg nkysg nkysg approved these changes

@jolestar jolestar Awaiting requested review from jolestar jolestar is a code owner

@LemonHX LemonHX Awaiting requested review from LemonHX LemonHX is a code owner

@welbon welbon Awaiting requested review from welbon

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonjiao @sanlee42 @nkysg