Transaction writeset store #3903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
运行下 ./scripts/check_commit.sh |
Benchmark for cc04b9cClick to view benchmark
|
nkysg
reviewed
Jun 1, 2023
nkysg
reviewed
Jun 1, 2023
| @@ -138,9 +143,11 @@ static VEC_PREFIX_NAME_V3: Lazy<Vec<ColumnFamilyName>> = Lazy::new(|| { | |||
| TRANSACTION_INFO_HASH_PREFIX_NAME, | |||
| CONTRACT_EVENT_PREFIX_NAME, | |||
| FAILED_BLOCK_PREFIX_NAME, | |||
| WRITE_SET_PRIFIX_NAME, | |||
There was a problem hiding this comment.
刚看了下升级这块，应该都是涉及到修改现有的结构，新增的话应该是不需要upgrade流程的
nkysg
reviewed
Jun 2, 2023
|
|
||
| fn to_write_set(access_path: AccessPath, value: Vec<u8>) -> WriteSet { | ||
| WriteSetMut::new(vec![ | ||
| ( |
nkysg
reviewed
Jun 2, 2023
executor/src/block_executor.rs
Outdated
| @@ -23,6 +26,7 @@ impl Default for BlockExecutedData { | |||
| state_root: HashValue::zero(), | |||
| txn_events: vec![], | |||
| txn_infos: vec![], | |||
| txn_write_sets: HashMap::default(), | |||
There was a problem hiding this comment.
这里为什么用HashMap,之前都是vec!, 这里有快速查找和插入需求吗？
There was a problem hiding this comment.
这里因为一个block涉及到多个transaction，map实现起来比较方便
There was a problem hiding this comment.
这里改成了vec，没改之前的考虑是方便说外面一对一的去取；改了之后的考虑是1. 如果有重复hashvalue则不会覆盖造成数据丢失，2. 存数据库时也是用的顺序存储
Codecov Report
@@ Coverage Diff @@
## master #3903 +/- ##
==========================================
+ Coverage 53.68% 53.77% +0.10%
==========================================
Files 618 622 +4
Lines 67991 68216 +225
==========================================
+ Hits 36492 36675 +183
- Misses 31499 31541 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmark for aeda101Click to view benchmark
|
nkysg
approved these changes
Jun 5, 2023
simonjiao
reviewed
Jun 26, 2023
chain/src/chain.rs
Outdated
| @@ -505,6 +506,10 @@ impl BlockChain { | |||
|
|
|||
| storage.save_block_info(block_info.clone())?; | |||
|
|
|||
| for (hash_value, write_set) in txn_write_set.iter() { | |||
There was a problem hiding this comment.
we can consume the txn_write_set, becase it will not be used any more.
There was a problem hiding this comment.
Passed it into batch save function
simonjiao
approved these changes
Jun 28, 2023
nkysg
reviewed
Jun 28, 2023
chain/src/chain.rs
Outdated
| @@ -505,6 +506,11 @@ impl BlockChain { | |||
|
|
|||
| storage.save_block_info(block_info.clone())?; | |||
|
|
|||
| for (hash_value, write_set) in txn_write_set{ | |||
| storage.save_write_set(hash_value, write_set)?; | |||
There was a problem hiding this comment.
看起来 storage.save_write_set可以弄成一个batch_write,你参考下save_transaction_batch看看是不是这样, batch_write主要是少了几次rocksdb调用，这个调用虽然比较小，再就是现在是一次性写入，现在是rocksdb异步刷盘，不是每次都flush磁盘，如果是同步就会每次都flush磁盘就很慢了. @welbon @simonjiao
|
It has some big change about WriteOp in move. WriteOp originals has two kinds of operations, Value and Delete. Now It becomes three kinds, Insert, Update and Delete. I think starcoin will consider to upgrade it. |
|
LGTM |
nkysg
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information