Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update move prover #3924

Merged
merged 6 commits into from Aug 2, 2023
Merged

update move prover #3924

merged 6 commits into from Aug 2, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jul 10, 2023 •
edited

update move prover

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited

Codecov Report

Merging #3924 (5577efb) into master (62f2b39) will increase coverage by 0.19%.
Report is 4 commits behind head on master.
The diff coverage is 70.51%.

❗ Current head 5577efb differs from pull request most recent head f7c606e. Consider uploading reports for the commit f7c606e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3924      +/-   ##
==========================================
+ Coverage   53.73%   53.91%   +0.19%     
==========================================
  Files         618      621       +3     
  Lines       68014    68128     +114     
==========================================
+ Hits        36539    36724     +185     
+ Misses      31475    31404      -71
Flag Coverage Δ
unittests 53.91% <70.51%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/peer-watcher/src/lib.rs 6.25% <0.00%> (ø)
cmd/starcoin/src/node/network/call_peer_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/network/get_address_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/network/known_peers_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/sync/start_cmd.rs 0.00% <ø> (ø)
config/src/network_config.rs 80.00% <ø> (ø)
network-p2p/core/src/delegates.rs 100.00% <ø> (ø)
network-p2p/core/src/lib.rs 36.07% <ø> (ø)
network-p2p/core/src/server.rs 93.75% <ø> (ø)
network-p2p/derive/src/helper.rs 76.32% <ø> (ø)
... and 42 more

... and 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236c0f2...f7c606e. Read the comment docs.

@nkysg nkysg force-pushed the move_prover_v6 branch 2 times, most recently from 3f183ae to e6c06ec Compare July 11, 2023 05:27
@nkysg nkysg requested review from welbon, simonjiao and jackzhhuang and removed request for jolestar, nanne007, yourmoonlight, templexxx and LemonHX July 31, 2023 23:28
simonjiao
simonjiao approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkysg nkysg merged commit c7af47a into master Aug 2, 2023
3 of 5 checks passed
@nkysg nkysg deleted the move_prover_v6 branch August 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjiao simonjiao simonjiao approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@welbon welbon Awaiting requested review from welbon

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkysg @simonjiao