Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parallel executor] parallel executor #3940

Merged
merged 33 commits into from Aug 28, 2023
Merged

[parallel executor] parallel executor #3940

merged 33 commits into from Aug 28, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Aug 18, 2023 •
edited

Pull request type

Feature parallel executor

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg mentioned this pull request Aug 18, 2023
Closed
7 tasks
@nkysg nkysg requested review from welbon, simonjiao and jackzhhuang and removed request for jolestar and yourmoonlight August 18, 2023 07:49
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited

Codecov Report

Merging #3940 (96490b8) into master (de1a00b) will decrease coverage by 0.49%.
Report is 3 commits behind head on master.
The diff coverage is 33.50%.

❗ Current head 96490b8 differs from pull request most recent head 2ee8c8a. Consider uploading reports for the commit 2ee8c8a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3940      +/-   ##
==========================================
- Coverage   54.23%   53.73%   -0.49%     
==========================================
  Files         621      636      +15     
  Lines       68466    69631    +1165     
==========================================
+ Hits        37125    37412     +287     
- Misses      31341    32219     +878
Flag Coverage Δ
unittests 53.73% <33.50%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/indexer/src/lib.rs 50.34% <0.00%> (-0.34%) ⬇️
executor/src/lib.rs 100.00% <ø> (ø)
node/src/node.rs 58.25% <ø> (ø)
rpc/api/src/types.rs 16.02% <0.00%> (-0.04%) ⬇️
storage/src/table_info/mod.rs 24.00% <0.00%> (+24.00%) ⬆️
test-helper/src/executor.rs 42.56% <0.00%> (-0.66%) ⬇️
types/src/error/mod.rs 0.00% <ø> (ø)
vm/parallel-executor/src/errors.rs 0.00% <0.00%> (ø)
vm/parallel-executor/src/executor.rs 0.00% <0.00%> (ø)
vm/parallel-executor/src/scheduler.rs 0.00% <0.00%> (ø)
... and 30 more

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641a902...2ee8c8a. Read the comment docs.

@nkysg nkysg mentioned this pull request Aug 28, 2023
Closed
7 tasks
welbon
welbon approved these changes Aug 28, 2023
View reviewed changes
node/src/node.rs Show resolved Hide resolved
@nkysg nkysg merged commit ef27ca5 into master Aug 28, 2023
3 of 5 checks passed
@nkysg nkysg deleted the parallel_executor_pr branch August 28, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welbon welbon welbon approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42 sanlee42 is a code owner

@simonjiao simonjiao Awaiting requested review from simonjiao

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkysg @welbon