Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[starcoin-framework] add stdlib v12 #3941

Merged
merged 8 commits into from Aug 30, 2023
Merged

[starcoin-framework] add stdlib v12 #3941

merged 8 commits into from Aug 30, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Aug 19, 2023 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

stdlib v12: https://github.com/starcoinorg/starcoin-framework/releases/tag/v12

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar as a code owner August 19, 2023 04:46
@nkysg nkysg requested review from sanlee42, welbon, simonjiao and jackzhhuang and removed request for jolestar August 19, 2023 04:49
@nkysg nkysg changed the title add stdlib v12 [starcoin-framework] add stdlib v12 Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited

Codecov Report

Merging #3941 (b113fa6) into master (de1a00b) will decrease coverage by 0.18%.
Report is 4 commits behind head on master.
The diff coverage is 14.29%.

❗ Current head b113fa6 differs from pull request most recent head b8cc732. Consider uploading reports for the commit b8cc732 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3941      +/-   ##
==========================================
- Coverage   54.23%   54.04%   -0.18%     
==========================================
  Files         621      621              
  Lines       68466    68465       -1     
==========================================
- Hits        37125    36998     -127     
- Misses      31341    31467     +126
Flag Coverage Δ
unittests 54.04% <14.29%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
vm/types/src/on_chain_config/gas_schedule.rs 98.52% <ø> (+0.15%) ⬆️
vm/types/src/on_chain_config/mod.rs 71.14% <ø> (ø)
vm/vm-runtime/src/starcoin_vm.rs 74.96% <14.29%> (ø)

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef27ca5...b8cc732. Read the comment docs.

@nkysg nkysg enabled auto-merge (squash) August 22, 2023 09:29
@nkysg nkysg disabled auto-merge August 22, 2023 09:29
simonjiao
simonjiao approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkysg nkysg merged commit 62fc18b into master Aug 30, 2023
3 of 5 checks passed
@nkysg nkysg deleted the stdlib_v12 branch August 30, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjiao simonjiao simonjiao approved these changes

@jackzhhuang jackzhhuang jackzhhuang approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@welbon welbon Awaiting requested review from welbon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkysg @simonjiao @jackzhhuang