[table] Feat tableinfo v2 #3942

simonjiao · 2023-08-19T11:22:43Z

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

codecov · 2023-08-19T12:21:38Z

Codecov Report

Merging #3942 (a374c2b) into master (de1a00b) will increase coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 75.00%.

❗ Current head a374c2b differs from pull request most recent head ea4b444. Consider uploading reports for the commit ea4b444 to get more accurate results

@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
+ Coverage   54.23%   54.28%   +0.05%     
==========================================
  Files         621      621              
  Lines       68466    68522      +56     
==========================================
+ Hits        37125    37188      +63     
+ Misses      31341    31334       -7

Flag	Coverage Δ
unittests	`54.28% <75.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
rpc/api/src/types.rs	`16.07% <0.00%> (ø)`
storage/src/table_info/mod.rs	`24.00% <0.00%> (+24.00%)`	⬆️
...rcoin-transactional-test-harness/src/fork_chain.rs	`0.00% <0.00%> (ø)`
vm/starcoin-transactional-test-harness/src/lib.rs	`0.11% <0.00%> (ø)`
vm/types/src/on_chain_config/gas_schedule.rs	`98.52% <ø> (+0.15%)`	⬆️
vm/types/src/on_chain_config/mod.rs	`71.14% <ø> (ø)`
vm/vm-runtime/src/starcoin_vm.rs	`75.00% <45.46%> (+0.05%)`	⬆️
vm/vm-runtime/src/move_vm_ext/session.rs	`81.92% <68.75%> (-3.08%)`	⬇️
vm/types/src/transaction/mod.rs	`55.84% <85.72%> (+1.07%)`	⬆️
chain/open-block/src/lib.rs	`79.80% <100.00%> (ø)`
... and 5 more

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5f1b8...ea4b444. Read the comment docs.

vm/types/src/transaction/mod.rs

storage/src/tests/test_storage.rs

storage/src/table_info/mod.rs

executor/src/block_executor.rs

storage/src/tests/test_storage.rs

nkysg · 2023-08-19T13:14:33Z

LGTM. I think you should upgrade name @simonjiao .

chain/src/chain.rs

vm/vm-runtime/src/starcoin_vm.rs

simonjiao added 2 commits August 19, 2023 19:21

uncomment tableinfo-related codes

72bb787

save tableinfo in starcoindb

a374c2b

simonjiao requested review from sanlee42, welbon and jackzhhuang August 19, 2023 11:22

simonjiao requested review from nkysg and jolestar as code owners August 19, 2023 11:22

add more comments

35cee05