Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] Feat tableinfo v2 #3942

Merged
merged 4 commits into from Aug 21, 2023
Merged

Conversation

simonjiao
Copy link
Collaborator

@simonjiao simonjiao commented Aug 19, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #3942 (a374c2b) into master (de1a00b) will increase coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 75.00%.

❗ Current head a374c2b differs from pull request most recent head ea4b444. Consider uploading reports for the commit ea4b444 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
+ Coverage   54.23%   54.28%   +0.05%     
==========================================
  Files         621      621              
  Lines       68466    68522      +56     
==========================================
+ Hits        37125    37188      +63     
+ Misses      31341    31334       -7     
Flag Coverage Δ
unittests 54.28% <75.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
rpc/api/src/types.rs 16.07% <0.00%> (ø)
storage/src/table_info/mod.rs 24.00% <0.00%> (+24.00%) ⬆️
...rcoin-transactional-test-harness/src/fork_chain.rs 0.00% <0.00%> (ø)
vm/starcoin-transactional-test-harness/src/lib.rs 0.11% <0.00%> (ø)
vm/types/src/on_chain_config/gas_schedule.rs 98.52% <ø> (+0.15%) ⬆️
vm/types/src/on_chain_config/mod.rs 71.14% <ø> (ø)
vm/vm-runtime/src/starcoin_vm.rs 75.00% <45.46%> (+0.05%) ⬆️
vm/vm-runtime/src/move_vm_ext/session.rs 81.92% <68.75%> (-3.08%) ⬇️
vm/types/src/transaction/mod.rs 55.84% <85.72%> (+1.07%) ⬆️
chain/open-block/src/lib.rs 79.80% <100.00%> (ø)
... and 5 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5f1b8...ea4b444. Read the comment docs.

@nkysg nkysg self-requested a review August 19, 2023 13:07
@nkysg
Copy link
Collaborator

nkysg commented Aug 19, 2023

LGTM. I think you should upgrade name @simonjiao .

chain/src/chain.rs Outdated Show resolved Hide resolved
@nkysg nkysg self-requested a review August 19, 2023 13:19
@nkysg nkysg merged commit 641a902 into starcoinorg:master Aug 21, 2023
2 of 4 checks passed
@nkysg nkysg changed the title Feat tableinfo v2 [table] Feat tableinfo v2 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants