Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel executor benchmark to master #3958

Merged
merged 21 commits into from Aug 29, 2023

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Aug 28, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

(cherry picked from commit dfb2588)
(cherry picked from commit a32fe9f)
(cherry picked from commit 491d14d)
(cherry picked from commit 586c1d0)
(cherry picked from commit 913de29)
(cherry picked from commit 563af3f)
(cherry picked from commit ff77776)
(cherry picked from commit a9e09c7)
(cherry picked from commit 9fbbad5)
@welbon welbon requested a review from jolestar as a code owner August 28, 2023 09:14
@nkysg
Copy link
Collaborator

nkysg commented Aug 29, 2023

please run ./script/check_commit.sh @welbon

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3958 (2adb21e) into master (de1a00b) will increase coverage by 0.75%.
Report is 4 commits behind head on master.
The diff coverage is 90.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3958      +/-   ##
==========================================
+ Coverage   54.23%   54.97%   +0.75%     
==========================================
  Files         621      640      +19     
  Lines       68466    70012    +1546     
==========================================
+ Hits        37125    38483    +1358     
- Misses      31341    31529     +188     
Flag Coverage Δ
unittests 54.97% <90.38%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/indexer/src/lib.rs 50.34% <0.00%> (-0.34%) ⬇️
cmd/starcoin/src/account/submit_txn_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/dev/concurrency_level_cmd.rs 0.00% <0.00%> (ø)
executor/src/lib.rs 100.00% <ø> (ø)
rpc/api/src/debug/mod.rs 100.00% <ø> (ø)
rpc/api/src/types.rs 16.02% <0.00%> (-0.04%) ⬇️
rpc/client/src/lib.rs 0.11% <0.00%> (-<0.01%) ⬇️
rpc/server/src/module/debug_rpc.rs 21.16% <0.00%> (-1.76%) ⬇️
storage/src/table_info/mod.rs 24.00% <0.00%> (+24.00%) ⬆️
test-helper/src/executor.rs 42.56% <0.00%> (-0.66%) ⬇️
... and 43 more

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef27ca5...2adb21e. Read the comment docs.

@nkysg nkysg requested review from nkysg, simonjiao, jackzhhuang and sanlee42 and removed request for jolestar August 29, 2023 14:09
@nkysg nkysg enabled auto-merge (squash) August 29, 2023 14:10
@nkysg nkysg merged commit 57a0415 into master Aug 29, 2023
3 of 5 checks passed
@nkysg nkysg deleted the parallel_executor_benchmark_to_master branch August 29, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants