Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib v12 gas schedule refactor #3960

Merged
merged 15 commits into from Sep 6, 2023
Merged

stdlib v12 gas schedule refactor #3960

merged 15 commits into from Sep 6, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Aug 31, 2023 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar as a code owner August 31, 2023 14:48
@nkysg nkysg changed the title stdlib 12 gas schedule refactor stdlib v12 gas schedule refactor Aug 31, 2023
@nkysg nkysg requested review from sanlee42, welbon, simonjiao and jackzhhuang and removed request for jolestar September 4, 2023 07:54
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited

Codecov Report

Merging #3960 (ccaaede) into master (de1a00b) will increase coverage by 0.48%.
Report is 7 commits behind head on master.
The diff coverage is 84.92%.

❗ Current head ccaaede differs from pull request most recent head b2f2b79. Consider uploading reports for the commit b2f2b79 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3960      +/-   ##
==========================================
+ Coverage   54.23%   54.70%   +0.48%     
==========================================
  Files         621      640      +19     
  Lines       68466    70069    +1603     
==========================================
+ Hits        37125    38326    +1201     
- Misses      31341    31743     +402
Flag Coverage Δ
unittests 54.70% <84.92%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/indexer/src/lib.rs 50.34% <0.00%> (-0.34%) ⬇️
cmd/starcoin/src/account/submit_txn_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/dev/concurrency_level_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/lib.rs 0.78% <0.00%> (-<0.01%) ⬇️
executor/src/lib.rs 100.00% <ø> (ø)
network-rpc/api/src/lib.rs 47.13% <0.00%> (-0.54%) ⬇️
network-rpc/api/src/remote_chain_state.rs 0.00% <0.00%> (ø)
network-rpc/src/rpc.rs 37.31% <0.00%> (-1.38%) ⬇️
node/src/node.rs 58.25% <ø> (ø)
rpc/api/src/debug/mod.rs 100.00% <ø> (ø)
... and 46 more

... and 29 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fc18b...b2f2b79. Read the comment docs.

@nkysg nkysg removed the request for review from yourmoonlight September 4, 2023 11:02
@nkysg nkysg merged commit 7698f19 into master Sep 6, 2023
3 of 5 checks passed
@nkysg nkysg deleted the gas_schedule_refactor branch September 6, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welbon welbon welbon approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@simonjiao simonjiao Awaiting requested review from simonjiao

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkysg @welbon