Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat schema batch write v2 #3964

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feat schema batch write v2 #3964

wants to merge 10 commits into from

Conversation

simonjiao
Copy link
Collaborator

@simonjiao simonjiao commented Sep 6, 2023 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Merging #3964 (977159f) into master (de1a00b) will increase coverage by 0.32%.
Report is 8 commits behind head on master.
The diff coverage is 58.80%.

❗ Current head 977159f differs from pull request most recent head 766b03d. Consider uploading reports for the commit 766b03d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3964      +/-   ##
==========================================
+ Coverage   54.23%   54.55%   +0.32%     
==========================================
  Files         621      653      +32     
  Lines       68466    70546    +2080     
==========================================
+ Hits        37125    38478    +1353     
- Misses      31341    32068     +727
Flag Coverage Δ
unittests 54.55% <58.80%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
account/src/account.rs 86.21% <0.00%> (ø)
account/src/account_manager.rs 69.50% <0.00%> (ø)
account/src/lib.rs 100.00% <ø> (ø)
cmd/indexer/src/lib.rs 50.34% <0.00%> (-0.34%) ⬇️
cmd/starcoin/src/account/submit_txn_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/dev/concurrency_level_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/lib.rs 0.78% <0.00%> (-<0.01%) ⬇️
executor/src/lib.rs 100.00% <ø> (ø)
network-rpc/api/src/lib.rs 47.13% <0.00%> (-0.54%) ⬇️
network-rpc/api/src/remote_chain_state.rs 0.00% <0.00%> (ø)
... and 71 more

... and 25 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7698f19...766b03d. Read the comment docs.

@simonjiao
minor updates
bbd87b7 
1.use get_pinned_cf instead of get_cf
2.reference db in AccountStore
3.make some members of DBStorage private
4.make StorageInstance generic
@simonjiao
Relax trait restrictions for schemadb
766b03d 
1. remove Default trait restriction for account storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar Awaiting requested review from jolestar jolestar is a code owner

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@welbon welbon Awaiting requested review from welbon

@nkysg nkysg Awaiting requested review from nkysg nkysg is a code owner

@LemonHX LemonHX Awaiting requested review from LemonHX

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@simonjiao