New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tps benchmark logs #3970
Open
welbon
wants to merge
24
commits into
block_executor_optimize_tps
Choose a base branch
from
tps_benchmark_logs
base: block_executor_optimize_tps
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tps benchmark logs #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welbon
requested review from
jolestar,
nkysg and
yourmoonlight
as code owners
September 25, 2023 11:28
nkysg
force-pushed
the
block_executor_optimize_tps
branch
from
September 26, 2023 00:17
ff5018c
to
bce6290
Compare
nkysg
reviewed
Sep 26, 2023
@@ -137,7 +137,7 @@ impl AccountCurrent { | |||
let received_events_count = initial_data.received_events_count(); | |||
Self { | |||
initial_data, | |||
balance, | |||
balance: balance as u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里balance不是变成u128了吗,是不是需要AccountCurrent定义里balance为u128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information