Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jh_hash function optimize bug in gcc11.4 #3978

Merged
merged 16 commits into from Nov 20, 2023
Merged

fix jh_hash function optimize bug in gcc11.4 #3978

merged 16 commits into from Nov 20, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Oct 19, 2023

#3848 need to solve ubuntu 22 block header difficulty, related code test_barnard_block3_on_ubuntu22 and scripts/verify_header.sh

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from sanlee42 as a code owner October 19, 2023 08:13
@nkysg nkysg requested a review from jolestar as a code owner October 23, 2023 14:42
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #3978 (3bb2016) into master (2436a7a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 3bb2016 differs from pull request most recent head 4fbbd1a. Consider uploading reports for the commit 4fbbd1a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3978      +/-   ##
==========================================
+ Coverage   54.49%   54.62%   +0.13%     
==========================================
  Files         640      640              
  Lines       70090    70097       +7     
==========================================
+ Hits        38186    38280      +94     
+ Misses      31904    31817      -87     
Flag Coverage Δ
unittests 54.62% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
consensus/src/consensus_test.rs 100.00% <100.00%> (ø)
types/src/block.rs 78.24% <100.00%> (ø)

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2436a7a...4fbbd1a. Read the comment docs.

@nkysg nkysg force-pushed the remove_ofast_test branch 2 times, most recently from 10c79d3 to 6a08426 Compare October 26, 2023 10:37
@nkysg nkysg changed the title remove cryptonight cpp compiler flag Ofast fix cryptonight cpp compiler flag Ofast on gcc11.4 error Oct 27, 2023
@nkysg nkysg changed the title fix cryptonight cpp compiler flag Ofast on gcc11.4 error fix cryptonight cpp compiler flag Ofast on gcc11.4 run error Oct 27, 2023
@nkysg nkysg linked an issue Oct 27, 2023 that may be closed by this pull request
@nkysg nkysg changed the title fix cryptonight cpp compiler flag Ofast on gcc11.4 run error fix jh_hash function optimize bug in gcc11.4 Oct 27, 2023
@nkysg nkysg merged commit 35c9a40 into master Nov 20, 2023
4 of 5 checks passed
@nkysg nkysg deleted the remove_ofast_test branch November 20, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMD cpu verify block failed
3 participants