Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types oom #3993

Merged
merged 2 commits into from Dec 19, 2023
Merged

fix types oom #3993

merged 2 commits into from Dec 19, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Nov 26, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3993 (8bda125) into master (2436a7a) will increase coverage by 0.28%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 8bda125 differs from pull request most recent head ba899cc. Consider uploading reports for the commit ba899cc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
+ Coverage   54.49%   54.76%   +0.28%     
==========================================
  Files         640      640              
  Lines       70090    70111      +21     
==========================================
+ Hits        38186    38387     +201     
+ Misses      31904    31724     -180     
Flag Coverage Δ
unittests 54.76% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
consensus/cryptonight-rs/src/lib.rs 100.00% <100.00%> (ø)
consensus/cryptonight-rs/src/tests.rs 78.73% <100.00%> (+5.04%) ⬆️
consensus/src/consensus_test.rs 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410d18f...ba899cc. Read the comment docs.

@nkysg nkysg merged commit c2482ce into master Dec 19, 2023
3 of 5 checks passed
@nkysg nkysg deleted the types_oom branch December 19, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants