New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block executor optimize tps testsuite #3995
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/build_test.yml
Outdated
@@ -3,7 +3,7 @@ on: | |||
workflow_dispatch: | |||
pull_request: | |||
branches: | |||
- master | |||
- block_executor_optimize_tps_validate | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里面的都的恢复吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -9,7 +9,7 @@ | |||
// JellyfishMerkleTree, | |||
// }; | |||
// use anyhow::Result; | |||
// use diem_crypto::HashValue; | |||
// use starcoin_crypto::HashValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这文件可以不修改吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件删出吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3995 +/- ##
==========================================
+ Coverage 54.49% 54.64% +0.15%
==========================================
Files 640 641 +1
Lines 70090 70806 +716
==========================================
+ Hits 38186 38682 +496
- Misses 31904 32124 +220
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- name: run fmt check | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: fmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件恢复原来吧
@@ -23,7 +23,7 @@ spec: | |||
starcoin/node-pool: seed-pool | |||
containers: | |||
- name: starcoin | |||
image: ghcr.io/starcoin/starcoin:v1.13.7 | |||
image: ghcr.io/starcoin/starcoin:v1.13.8 | |||
imagePullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要rebase下master
publish = { workspace = true } | ||
version = "1.13.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这需要rebase下master
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information