Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: Excluded transactions from blacklisted addresses during create block template #4008

Merged
merged 6 commits into from Mar 7, 2024

Conversation

sanlee42
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@sanlee42 sanlee42 requested a review from nkysg as a code owner February 19, 2024 15:02
@sanlee42 sanlee42 force-pushed the miner_blacklist branch 4 times, most recently from bf938f3 to 7f432f1 Compare February 20, 2024 12:46
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.79%. Comparing base (50d34f8) to head (82b6c1e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
+ Coverage   54.58%   54.79%   +0.21%     
==========================================
  Files         640      640              
  Lines       70957    70982      +25     
==========================================
+ Hits        38726    38888     +162     
+ Misses      32231    32094     -137     
Flag Coverage Δ
unittests 54.79% <89.29%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
chain/open-block/src/lib.rs 80.19% <94.45%> (+2.41%) ⬆️
chain/src/verifier/mod.rs 76.96% <80.00%> (+0.14%) ⬆️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d34f8...82b6c1e. Read the comment docs.

@sanlee42 sanlee42 merged commit d0e1ed2 into master Mar 7, 2024
6 of 7 checks passed
@sanlee42 sanlee42 deleted the miner_blacklist branch March 7, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants