Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain add directly save special block without execute #4013

Merged
merged 14 commits into from Mar 5, 2024
Merged

chain add directly save special block without execute #4013

merged 14 commits into from Mar 5, 2024

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Feb 27, 2024 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar as a code owner February 27, 2024 05:45
simonjiao
simonjiao approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkysg nkysg merged commit 50d34f8 into master Mar 5, 2024
13 of 18 checks passed
@nkysg nkysg deleted the attack_fix branch March 5, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjiao simonjiao simonjiao approved these changes

@jolestar jolestar Awaiting requested review from jolestar jolestar is a code owner

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@welbon welbon Awaiting requested review from welbon

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkysg @simonjiao