Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some comments #4017

Merged
merged 1 commit into from Mar 8, 2024
Merged

fix some comments #4017

merged 1 commit into from Mar 8, 2024

Conversation

hishope
Copy link
Contributor

@hishope hishope commented Mar 7, 2024 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@hishope
fix some comments
f30094e 
Signed-off-by: hishope <csqiye@126.com>
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.86%. Comparing base (50d34f8) to head (f30094e).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
+ Coverage   54.58%   54.86%   +0.29%     
==========================================
  Files         640      640              
  Lines       70957    70957              
==========================================
+ Hits        38726    38925     +199     
+ Misses      32231    32032     -199
Flag Coverage Δ
unittests 54.86% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/starcoin/src/account/verify_sign_cmd.rs 0.00% <ø> (ø)
commons/accumulator/src/node_index.rs 93.41% <ø> (ø)
network-p2p/src/protocol/event.rs 16.67% <ø> (ø)
network/src/service.rs 76.22% <100.00%> (-0.44%) ⬇️
vm/compiler/src/dependency_order.rs 0.00% <ø> (ø)
vm/mvhashmap/src/unit_tests/mvhashmap_test.rs 100.00% <100.00%> (ø)
vm/parallel-executor/src/executor.rs 99.20% <100.00%> (ø)
vm/parallel-executor/src/scheduler.rs 98.19% <ø> (ø)
vm/parallel-executor/src/txn_last_input_output.rs 95.39% <ø> (ø)
vm/types/src/on_chain_config/gas_schedule.rs 98.52% <100.00%> (ø)
... and 2 more

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d34f8...f30094e. Read the comment docs.

@nkysg
Copy link
Collaborator

nkysg commented Mar 8, 2024

Thanks.

@nkysg nkysg merged commit 65c06a3 into starcoinorg:master Mar 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkysg nkysg nkysg approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42 sanlee42 is a code owner

@jolestar jolestar Awaiting requested review from jolestar jolestar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hishope @nkysg