Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encodeScriptFunctionByResolve address is array bug #47

Merged
merged 3 commits into from May 12, 2022
Merged

fix encodeScriptFunctionByResolve address is array bug #47

merged 3 commits into from May 12, 2022

Conversation

uvd
Copy link
Contributor

@uvd uvd commented May 12, 2022 •
edited

#46

wk3368
wk3368 requested changes May 12, 2022
View reviewed changes
src/encoding/index.spec.ts Outdated

test("encodeScriptFunctionByResolve5", async () => {
const addressArray = ["0x22a19240709CB17ec9523252AA17B997"];
const amountArray = [11];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const STC_SCALLING_FACTOR = 1000000000
const amountArray = [11 * STC_SCALLING_FACTOR];

src/encoding/index.spec.ts Outdated
@@ -289,6 +289,24 @@ test("encodeScriptFunctionByResolve4", async () => {
// expect(payloadInHex).toBe(hexExpected);
}, 10000);


test("encodeScriptFunctionByResolve5", async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename this to encodeScriptFunctionByResolve6

wk3368
wk3368 approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@wk3368 wk3368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wk3368 wk3368 merged commit 6ea17db into starcoinorg:master May 12, 2022
@uvd uvd deleted the feature/fix_address_is_array branch June 7, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wk3368 wk3368 wk3368 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uvd @wk3368