Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generateMultiEd25519SignatureShard have console.log #51

Merged
merged 1 commit into from May 18, 2022
Merged

Fix generateMultiEd25519SignatureShard have console.log #51

merged 1 commit into from May 18, 2022

Conversation

WGB5445
Copy link
Contributor

@WGB5445 WGB5445 commented May 18, 2022 •
edited

SDK should not use console.log to print something by default

So I removed the console.log in generateMultiEd25519Signature and generateMultiEd25519SignatureShard

wk3368
wk3368 approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@wk3368 wk3368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wk3368 wk3368 merged commit 605767f into starcoinorg:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wk3368 wk3368 wk3368 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WGB5445 @wk3368